[Do not merge until MSAL.NET 4.0 releases] Jmprieur/msal4.0 #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the async serialization in the SessionTokenCacheProviders
Updating README.md with a sample connection string, for localdb
- proposing a localdb connection string as a comment in the appsettings.json - Now, uncommenting the comments still builds (and it's obvious now which), now builds correctly (renamed tokenCacheDbContext into tokenCacheDbContextForCreation as it used to conflict with the tokenCacheDbContext in the AddScoped block
jmprieur
requested review from
kalyankrishna1,
MarkZuber,
bgavrilMS,
jennyf19,
trwalke,
henrik-me and
TiagoBrenck
jmprieur
commented
May 31, 2019
| @@ -119,9 +125,9 @@ public void Clear() | |||
| /// Triggered right before MSAL needs to access the cache. Reload the cache from the persistence store in case it changed since the last access. | |||
| /// </summary> | |||
| /// <param name="args">Contains parameters used by the MSAL call accessing the cache.</param> | |||
| private void AppTokenCacheBeforeAccessNotification(TokenCacheNotificationArgs args) | |||
| private async Task AppTokenCacheBeforeAccessNotificationAsync(TokenCacheNotificationArgs args) | |||
There was a problem hiding this comment.
And therefore the callback are async
jmprieur
commented
May 31, 2019
| { | ||
| this.HttpContext.Session.LoadAsync().Wait(); | ||
| await this.HttpContext.Session.LoadAsync(); |
There was a problem hiding this comment.
And we don't need to block any longer!
jmprieur
commented
May 31, 2019
|
|
||
| //var tokenCacheDbContext = new TokenCacheDbContext(tokenCacheDbContextBuilder.Options); | ||
| //tokenCacheDbContext.Database.EnsureCreated(); | ||
| /* |
There was a problem hiding this comment.
Transforming in /* comments so that it's obvious what to uncomment
jmprieur
commented
May 31, 2019
|
|
||
| var tokenCacheDbContextForCreation = new TokenCacheDbContext(tokenCacheDbContextBuilder.Options); |
There was a problem hiding this comment.
Renamed tokenCacheDbContext -> tokenCacheDbContextForCreation as there was a conflict
jmprieur
changed the title
jennyf19
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update the sample to MSAL.NET 4.0
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Follow the README.md